Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derived feature bugfix #121

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Derived feature bugfix #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion feathr_project/feathr/feature_derivations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def to_feature_config(self) -> str:
}
{% endfor %}
}
definition.sqlExpr: {{derived_feature.transform.to_feature_config(False)}}
definition: {{derived_feature.transform.to_feature_config(False)}}
{{derived_feature.feature_type.to_feature_config()}}
}
""")
Expand Down
10 changes: 5 additions & 5 deletions feathr_project/test/test_derived_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def test_single_key_derived_feature_to_config():
inputs: {
user_embedding: {key: [user_id], feature: user_embedding}
}
definition.sqlExpr: "if_else(user_embedding, user_embedding, [])"
definition: "if_else(user_embedding, user_embedding, [])"
type: {
type: TENSOR
tensorCategory: DENSE
Expand Down Expand Up @@ -58,7 +58,7 @@ def test_multikey_derived_feature_to_config():
user_embedding: {key: [user_id], feature: user_embedding}
item_embedding: {key: [item_id], feature: item_embedding}
}
definition.sqlExpr: "similarity(user_embedding,item_embedding)"
definition: "similarity(user_embedding,item_embedding)"
type: {
type: TENSOR
tensorCategory: DENSE
Expand Down Expand Up @@ -88,7 +88,7 @@ def test_derived_feature_to_config_with_alias():
viewer_embedding: {key: [viewer], feature: user_embedding}
viewee_embedding: {key: [viewee], feature: user_embedding}
}
definition.sqlExpr: "distance(viewer_embedding, viewee_embedding)"
definition: "distance(viewer_embedding, viewee_embedding)"
type: {
type: TENSOR
tensorCategory: DENSE
Expand Down Expand Up @@ -129,7 +129,7 @@ def test_multi_key_derived_feature_to_config_with_alias():
viewer_viewee_distance: {key: [viewer, viewee], feature: viewer_viewee_distance}
viewee_viewer_distance: {key: [viewee, viewer], feature: viewer_viewee_distance}
}
definition.sqlExpr: "viewer_viewee_distance + viewee_viewer_distance"
definition: "viewer_viewee_distance + viewee_viewer_distance"
type: {
type: TENSOR
tensorCategory: DENSE
Expand Down Expand Up @@ -159,7 +159,7 @@ def test_derived_feature_on_multikey_anchored_feature_to_config():
inputs: {
user_embedding: {key: [viewer, viewee], feature: user_embedding}
}
definition.sqlExpr: "if_else(user_embedding, user_embedding, [])"
definition: "if_else(user_embedding, user_embedding, [])"
type: {
type: TENSOR
tensorCategory: DENSE
Expand Down