Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity creation APIs #387

Merged
merged 8 commits into from
Jun 27, 2022
Merged

Entity creation APIs #387

merged 8 commits into from
Jun 27, 2022

Conversation

windoze
Copy link
Member

@windoze windoze commented Jun 23, 2022

SQL registry now support entity creation.
Before this PR the SQL registry solely worked with UI without creating functions.

YihuiGuo
YihuiGuo previously approved these changes Jun 23, 2022
View reviewed changes
Yuqing-cat
Yuqing-cat reviewed Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@Yuqing-cat Yuqing-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very important prerequisite PR for access control features. Very helpful enhancement.
I would suggest moving database.py to a common folder under /registry so that sql-based access control can reuse it.
Also, are the interface.py and models.py a common description for all backend registries? If so, shall we move those common definition outside of sql-registry?

registry/sql-registry/registry/models.py Outdated Show resolved Hide resolved
@windoze
Copy link
Member Author

windoze commented Jun 24, 2022

This is a very important prerequisite PR for access control features. Very helpful enhancement. I would suggest moving database.py to a common folder under /registry so that sql-based access control can reuse it. Also, are the interface.py and models.py a common description for all backend registries? If so, shall we move those common definition outside of sql-registry?

I plan to submit another following up PR for re-structuring, don't want to mess up before function stabilization.

Yuqing-cat
Yuqing-cat previously approved these changes Jun 24, 2022
View reviewed changes
@Yuqing-cat
Copy link
Collaborator

plan to submit another following up PR for re-structuring, don't want to mess up before function stabilization.

Agree, I can also help to do this my access control PR.

@YihuiGuo YihuiGuo mentioned this pull request Jun 26, 2022
Closed
@windoze windoze merged commit 8c6bd27 into main Jun 27, 2022
@YihuiGuo YihuiGuo mentioned this pull request Jun 27, 2022
Merged
@xiaoyongzhu xiaoyongzhu deleted the windoze/sql-registry-create branch August 22, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YihuiGuo YihuiGuo YihuiGuo left review comments

@blrchen blrchen blrchen approved these changes

@Yuqing-cat Yuqing-cat Yuqing-cat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@windoze @Yuqing-cat @blrchen @YihuiGuo