Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Bugs reported during oncall #908

Merged
merged 3 commits into from
Dec 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/how-to-guides/azure_resource_provision.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,14 @@
"sqlAdminUsername": {
"type": "String",
"metadata": {
"description": "Specifies the username for SQL Database admin"
"description": "Specify the username for SQL Database admin"
}
},
"sqlAdminPassword": {
"type": "SecureString",
"metadata": {
"description": "Specifies the password for SQL Database admin"
"description": "Specify the password for SQL Database admin. Please note that the password can't contain semicolon (;)
as it conflicts with connection string delimiter"
}
},
"registryBackend": {
Expand Down
58 changes: 52 additions & 6 deletions docs/samples/azure_synapse/product_recommendation_demo.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,14 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"## 2. Prerequisite: Login to Azure and Install Feathr\n",
"\n",
"Login to Azure with a device code (You will see instructions in the output once you execute the cell):"
"## 2. Prerequisite: Install Feathr and it's dependencies and Login to Azure"
]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"Install Feathr and dependencies to run this notebook. Normally you could run all the pip installs in one line, but when running this notebook in synapse, you may get some errors or blocks installing above packages in one cell. Hence installing them in different cells."
]
},
{
Expand All @@ -48,14 +53,41 @@
"metadata": {},
"outputs": [],
"source": [
"! az login --use-device-code"
"%pip install -U feathr"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"%pip install -U azure-cli"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"%pip install -U pandavro"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"%pip install -U scikit-learn"
]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"Install Feathr and dependencies to run this notebook."
"Login to Azure with a device code (You will see instructions in the output once you execute the cell):"
]
},
{
Expand All @@ -64,7 +96,7 @@
"metadata": {},
"outputs": [],
"source": [
"%pip install -U feathr pandavro scikit-learn"
"! az login --use-device-code"
]
},
{
Expand Down Expand Up @@ -103,6 +135,13 @@
"from azure.keyvault.secrets import SecretClient"
]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"If you meet errors like 'cannot import FeatherClient from feathr', it may be caused by incompatible version of 'aiohttp'. Please try to install/upgrade it by running: '%pip install aiohttp==3.8.3'"
]
},
{
"cell_type": "markdown",
"metadata": {},
Expand All @@ -124,6 +163,13 @@
"```\n"
]
},
{
"cell_type": "markdown",
"metadata": {},
"source": [
"If you run into issues where Key vault or other resources are not found through notebook despite being there, make sure you are connected to the right subscription by running the command: 'az account show' and 'az account set --subscription <subscription_id>'"
]
},
{
"cell_type": "markdown",
"metadata": {},
Expand Down