Update Feature.sol

[0xScratch]

This PR aims for two types of optimizations:

• Changing constant to immutable for variables storing the keccak hashes. Refer this
• Improvement of 'for' loops. Refer this

Some typos were fixed

Also, there's one more fix we can make in the structs. The structs which are used currently are kind of using more slots than required which costs more gas. If we aim to pack structs, then it be more efficient

Thanks!

[0xScratch]

Fixed the code readability which was messed up on line 662 (Refer feature.sol)

[n1c01a5]

Thank you @Aryan9592 for your contribution !

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Feature Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

[0xScratch]

Also, there's one more fix we can make in the structs. The structs which are used currently are kind of using more slots than required which costs more gas. If we aim to pack structs, then it be more efficient

@n1c01a5 what about this?

[n1c01a5]

Also, there's one more fix we can make in the structs. The structs which are used currently are kind of using more slots than required which costs more gas. If we aim to pack structs, then it be more efficient

@n1c01a5 what about this?

I would not prioritarize this refactoring but feel free to do it.

@Aryan9592 I had never heard of this optimization before. Thank you for teaching it to me!

[0xScratch]

@n1c01a5 Rareskills really explained it in a hard way. This is a clear one https://gist.github.com/grGred/9bab8b9bad0cd42fc23d4e31e7347144#pack-structs-in-solidity

I be implementing this one in feature.sol. If you felt it good, gonna implement the same in rest!