Remove all nulls #402
Remove all nulls #402
Conversation
Refactors the entire code base to remove all usages for null as a values, and all null checks. When needed, data structures are updated to use java.util.Optional, but in a lot of cases null are removed without replacement.
Fix the Lizzie window not actually starting centered. Remove the 0.98 factor on board size to remove the small region of background above the board. Fix an exception when creating a BufferedImage with width zero.
OlivierBlanvillain
force-pushed
the
no-null
branch
from
384d301 to
3923312
Compare
|
wow, thanks :). I'll try to finish up all of the stuff for 0.6 now. |
|
I'm checking. |
|
Do you have any PR you would really like to get in before 0.6? I can focus on reviewing them this week. The fear is that if we wait for the PR queue to be empty but continue working like we do now, we will never release. I think it would be fine to release 0.6, and 0.7 in a month or something...
Either way, but I will try to keep the workload related to this PR on my shoulders. I'm happy to get everything merged first, then I will rebase this PR on top of whatever changed, or the other way around, we could merge this first and I will help fixing and updating other PRs like I did for the big one on auto formatting. |
|
Ok, let's finish it together and I will complete the review as soon as possible. I will not submit a new PR until then. |
|
I reviewed all the changes and there was basically no problem. There are a few minor questions, I will test it later. |
|
@OlivierBlanvillain |
|
LGTM. |
|
@zsalch Thanks for taking the time to finish this, I'm glad it got in! Unfortunately I will have virtually no time for Lizzie for the next 10 days... |
This PR refactors the entire code base to remove all usages for null as a values, and all null checks. When needed, data structures are updated to use
java.util.Optional, but in a lot of cases null are removed without replacement.The second commit re-implements
nextBranchandpreviousBranchin functional style (best reviewed commit by commit).We should probably branch off for v0.6 before merging this in case I missed something, but if possible I would like to avoid rebasing this for too long ^^'