-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calendar entries with "Event Name" #3818
Comments
In the API, 2 things need to be updated:
In the front-end, I think we need to change this fec-cms/fec/fec/static/js/modules/calendar.js Lines 175 to 187 in 32e66a8
We think this is because this template isn't properly displaying fec-cms/fec/fec/static/js/templates/calendar/events.hbs Lines 4 to 6 in 321c89b
|
@johnnyporkchops @djgarr @lbeaufort @patphongs Below are mockups of what the tooltip will look like on the calendar view. I plan to provide additional mockups for the view on mobile/list view as well. This is what I have so far. To achieve this look we will need to address the issue in this ticket as well. It's possible that both can be achieved with a single PR. |
These look good to me. Thanks! |
@johnnyporkchops @djgarr @patphongs @lbeaufort @dorothyyeager Some things to note in both of these views is the addition of "Location:" language. Currently states are abbreviated, but that's not in the API, so not sure how that's happening. Also, I modified the date area to show the day of the week. Ex. "Wednesday, December 3, 2020" |
Thanks @JonellaCulmer, mock ups look good. I think the data in the calendar endpoint is ported directly from the internal calendar tool database without much change. So it's possible the internal tool does not abbreviate states, and hence it gets imported into the calendar endpoint not abbreviated. |
@patphongs Thanks for that info. It appears that sometimes we abbreviate and sometimes we don't. @djgarr Do you think we abbreviate when it's more than one place? Or is there another reason? I think we need to be consistent in all places. |
@JonellaCulmer You are correct. When it's only one state, I've been spelling it out when entering the information into Disclosure. When it's more, I've been going with the abbreviations |
@djgarr Can the lists be long? The second example I showed with two locations is short, but are there really longs lists too? Like 10-15 locations? |
@JonellaCulmer Yes |
@djgarr I think we're good to leave it as is for now then! Thanks! I'm going to open up a followup implementation ticket for this. |
Closing in favor of #4111 |
Summary
When entering information into the Disclosure database, we add a field for "Event Name". When we transitioned to the new website, that information dropped off the entry. Trying to see if it can be added back.
When we enter data into the Disclosure database, we enter information for:
-Event Name
-Category
-Date
-Location
-URL
-Description
Right now, the information for the category, date, location, url, and description show up:
Related issues
Completion Criteria
The text was updated successfully, but these errors were encountered: