Temporarily Remove SSF/Leadership PACS options from Disbursements datatable

[johnnyporkchops]

Summary

Remove Separate segregated funds (SSF) and Leadership PAC options from Disbursements datatable > Filters > Spender Committee Type > PACS dropdown

• Resolves Remove SSFs from Sch B datatables #2966
  Related PR: Remove SSFs from receipts and individual contributions datatable #2941

Changed spender-committee-types.jinja partial to macro, added ssf conditional option.

It may have been possible to reuse the commitee-types.jinja macro here since currently the options are the same for both rasing and spending datatables-- But, this macro should remain separate in case we ever need to have different filter options for Disbursements VS. raising datatables( Receipts , Individual Contributions) .

Impacted areas of the application

renamed: data/templates/partials/filters/spender-committee-types.jinja -> data/templates/macros/filters/spender-committee-types.jinja
modified: data/templates/partials/disbursements-filter.jinja

How to test

• checkout and run branch
• go to http://127.0.0.1:8000/data/disbursements/
• Look at Filters > Spender Committee Type > PACS dropdown
• Make sure Leadership PAC option has been removed
• Make sure the Separate segregated funds (SSF) section has been removed. The last item in the dropdown should be : PAC with non-contribution account - qualified

[JonellaCulmer]

I think we're also removing Leadership PACs from the dropdown too.

[codecov-io]

Codecov Report

Merging #2979 into release/public-20190625 will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           release/public-20190625    #2979   +/-   ##
========================================================
  Coverage                    74.83%   74.83%           
========================================================
  Files                          119      119           
  Lines                         7126     7126           
  Branches                       615      615           
========================================================
  Hits                          5333     5333           
  Misses                        1793     1793

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe82b7f...9ba3a95. Read the comment docs.

[johnnyporkchops]

@JonellaCulmer , I added exclusion for Leadership PACs as requested in your review.

[lbeaufort]

Thanks @johnnyporkchops! Per our discussion, can you:

1. Target the release branch since the receipts change is already in the release
2. Remove "Lobbyist/Registrant PAC" from disbursements
3. Put in a PR to the release branch to remove "Lobbyist/Registrant PAC" and "Leadership PAC" from receipts? These filters don't work either.

[johnnyporkchops]

With this PR:

1. SSF, Leadership PAC and Lobbyist/Reg PAC have been removed from /Disbursements datatable

2. SSF, Leadership PAC and Lobbyist/Reg PAC have been removed from /Receipts and /Individual Contributions datatables (the work was started in PR Remove SSFs from receipts and individual contributions datatable #2941 and continued in this PR)

[lbeaufort]

Looks great, thanks @johnnyporkchops!