Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .gov banner with revised text #4049

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Update .gov banner with revised text #4049

merged 1 commit into from
Sep 22, 2020

Conversation

patphongs
Copy link
Member

Summary

Impacted areas of the application

List general components of the application that this PR will affect:

  • .gov banner at the top of all pages

Screenshots

Screen Shot 2020-09-17 at 10 39 46 AM

How to test

  • checkout this branch
  • npm run build just in case for styles
  • ./manage.py runserver
  • Click on the "Here's how you know ^" banner up at the top to expand it. The language should be updated as specified in the ticket.

JonellaCulmer
JonellaCulmer requested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great. Can we bold the word "lock"?

@patphongs patphongs force-pushed the feature/3940-update-gov-banner branch from 4bb252a to dc63214 Compare September 21, 2020 15:13
@patphongs
Copy link
Member Author

patphongs commented Sep 21, 2020 •
edited
Loading

Looks really great. Can we bold the word "lock"?

Thanks, it's been bolded @JonellaCulmer

johnnyporkchops
johnnyporkchops approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@johnnyporkchops johnnyporkchops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

JonellaCulmer
JonellaCulmer approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @patphongs. Looks good!

@JonellaCulmer JonellaCulmer merged commit 393f85f into develop Sep 22, 2020
@lbeaufort lbeaufort deleted the feature/3940-update-gov-banner branch November 3, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyporkchops johnnyporkchops johnnyporkchops approved these changes

@JonellaCulmer JonellaCulmer JonellaCulmer approved these changes

Assignees
No one assigned
Labels
Please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update government website banner
3 participants
@patphongs @johnnyporkchops @JonellaCulmer