updated redirect for /efiling and added redirect for /support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,8 +45,10 @@ rewrite ^/info/filing.shtml /help-candidates-and-committees/ redirect; | |||
| rewrite ^/info/report_dates_2017.shtml https://transition.fec.gov/info/report_dates_2017.shtml redirect; | |||
| rewrite ^/pdf/eleccoll.pdf https://transition.fec.gov/pdf/eleccoll.pdf redirect; | |||
| rewrite ^/elecfil/electron.shtml https://transition.fec.gov/elecfil/electron.shtml redirect; | |||
| rewrite ^/efiling /help-candidates-and-committees/electronic-filing/ redirect; | |||
| rewrite ^/efiling/ /help-candidates-and-committees/electronic-filing/ redirect; | |||
| rewrite ^/efiling /help-candidates-and-committees/filing-reports/electronic-filing/ redirect; | |||
There was a problem hiding this comment.
Maybe I am wrong but I thought the ^ means batch things that begin with that string. in that case you don't heed the next line or the second support line.
There was a problem hiding this comment.
Thanks for catching that @LindsayYoung. You are correctly, there is no need for the redirects with trailing slashes. I'll remove them.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/18F/fec-proxy/issues/49. Also added redirect for /support for efiling as discussed in content slack channel.