feature/1786 - Fixed issue with interest rate and due date being cleared when loaded from backend #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsistent, repeatable copying without missing steps
sasha-dresden
force-pushed
the
feature/1786-3
branch
from
f01b269 to
bee9f6d
Compare
|
toddlees
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue FECFILE-1786
Issue was that we were clearing the due date and interest rate fields when the corresponding setting field changed. Which is what we normally want now. However this was also happening on load from the backend.
Added a new component variable clearValuesOnChange which is always true except for when loading data from backend.
I also cleaned up the code to make it a bit easier to work with by making some getters and setters for the fields and field values.
And one other thing I noticed, there was bit of a wierd blip in validation with the secured radio button. Since it was validating on blur, you would click the button, and then briefly see a required validation when you blurred away. Added it to the onChange list, which I imagine all radio button inputs probably should be validating on change rather than blur.