Remove duplicative out of scope clause #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't clear what "it" referred to in this little addendum, but then I realized that there was an explicit "out of scope" section for saying these sorts of things. Added an Oxford comma for good measure.
|
Having an out-of-scope section was fairly important to several parties. If it is redundant but not contradictory, we'd like to leave it in (while adding an oxford comma and clarifying 'it'). Would that be acceptable to you? |
|
We've left the out-of-scope, though with some other revision via PR 21. Closing this out in favor the changes in that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't clear what "it" referred to in this little addendum, but then I realized that there was an explicit "out of scope" section for saying these sorts of things.
Added an Oxford comma for good measure.