Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ssh run_expensive() method should have a _safe() variant #3118

Closed
praiskup opened this issue Jan 26, 2024 · 0 comments · Fixed by #3124
Closed

The ssh run_expensive() method should have a _safe() variant #3118

praiskup opened this issue Jan 26, 2024 · 0 comments · Fixed by #3124
Assignees
@praiskup
Labels
release-blocker

Comments

@praiskup
Copy link
Member

praiskup commented Jan 26, 2024 •
edited
Loading

The command-over-ssh may produce a large output, feeding backend's memory
and DoS it. With #2977 merged, we should make sure the output is somewhat
safe to read into memory (e.g. piping through /usr/bin/head on-host, as the
remote utility is not trusted).
@github-project-automation github-project-automation bot moved this to Needs triage in CPT Kanban Jan 26, 2024
@praiskup praiskup moved this from Needs triage to In 3 months in CPT Kanban Jan 29, 2024
@nikromen nikromen moved this from In 3 months to In Progress in CPT Kanban Jan 29, 2024
@praiskup praiskup mentioned this issue Feb 2, 2024
Merged
praiskup added a commit to praiskup/copr that referenced this issue Feb 2, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
8ab4777 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 2, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
8fb2d26 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 2, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
7d946fe 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 2, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
0499624 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 3, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
7eac1f9 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 3, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
c297eb6 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 3, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
d0e07f9 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 3, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
274bee2 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 4, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
2e08ec5 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 4, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
67e0138 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 5, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
64ad277 
Fixes: fedora-copr#3118
praiskup added a commit to praiskup/copr that referenced this issue Feb 5, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
8826eab 
Fixes: fedora-copr#3118
praiskup added a commit that referenced this issue Feb 5, 2024
@praiskup
backend: limit stdout/stderr of ssh.run_expensive() commands
43dba77 
Fixes: #3118
@praiskup praiskup moved this from In Progress to Done in CPT Kanban Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@praiskup praiskup

Labels
release-blocker
Projects
CPT Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backend: limit stdout/stderr of ssh.run_expensive() commands praiskup/copr
1 participant
@praiskup