-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExclusiveArch skipping something it shouldn't #3244
Comments
This would be OK after moving to F40 builders where zig-srpm-macros package exists; but on our builders, %zig_arches is undefined. |
I believe the reverse also holds. For a package that has In the build log I see
I've seen skipped results before for excluded arches. Albeit, that was when a package excluded If this is a different issue, I can open a new ticket. |
triage: moving builders to fedora 40 will resolve this |
One of the workarounds that we discussed today is to detect unexpanded macros in exclusivearch ( |
…aluated Fix fedora-copr#3244 It can happen that our builder doesn't understand some architecture macro, e.g. `%{zig_arches}`. In such a case when it is used in `ExclusiveArch`, we shouldn't skip all chroots like we do now. A better approach is to be safe and avoid any skipping. Builds will fail in some chroots that should have been skipped but that can be workarounded by the user by manually submitting the build only for a subset of chroots.
…udeArch evaluated Fix fedora-copr#3244 It can happen that our builder doesn't understand some architecture macro, e.g. `%{zig_arches}`. In such a case when it is used in `ExclusiveArch`, we shouldn't skip all chroots like we do now. A better approach is to be safe and avoid any skipping. Builds will fail in some chroots that should have been skipped but that can be workarounded by the user by manually submitting the build only for a subset of chroots.
…udeArch evaluated Fix fedora-copr#3244 It can happen that our builder doesn't understand some architecture macro, e.g. `%{zig_arches}`. In such a case when it is used in `ExclusiveArch`, we shouldn't skip all chroots like we do now. A better approach is to be safe and avoid any skipping. Builds will fail in some chroots that should have been skipped but that can be workarounded by the user by manually submitting the build only for a subset of chroots.
We have for example this build which was skipped because of an
ExclusiveArch
https://copr.fedorainfracloud.org/coprs/sentry/zig-tools/build/7399386/
It uses
ExclusiveArch: %{zig_arches}
which on my laptop evaluates asso it IMHO should be built for x86_64 chroots - but it was skipped.
Full spec file as a backup:
The text was updated successfully, but these errors were encountered: