This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
consumer: Refactor the code to handle F28 Two week atomic #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanchowdhury
force-pushed
the
feature/refactor-consumer-image-meta
branch
from
515e48b to
4b218f6
Compare
dustymabe
reviewed
May 1, 2018
fedimg/consumers.py
Outdated
|
|
||
| if images_meta is None: |
There was a problem hiding this comment.
The changes here are mostly cosmetic right? There is no bug getting fixed here?
There was a problem hiding this comment.
Yes, these changes are cosmetic changes and fixes the broken tests.
There was a problem hiding this comment.
Since the changes don't actually change any functionality, how do they fix broken tests?
dustymabe
reviewed
May 1, 2018
fedimg/consumers.py
Outdated
| images_meta.extend(get_value_from_dict( | ||
| compose_metadata, 'images', 'payload', | ||
| 'images', 'AtomicHost', 'x86_64')) | ||
| images_meta = cloud_meta + atomic_meta |
There was a problem hiding this comment.
this if/else block is confusing.. I think I'd rather see something like:
images_meta = []
if cloud_meta:
images_meta.extend(cloud_meta)
if atomic_meta:
images_meta.extend(atomic_meta)
Signed-off-by: Sayan Chowdhury <[email protected]>
sayanchowdhury
force-pushed
the
feature/refactor-consumer-image-meta
branch
from
4b218f6 to
b210d6b
Compare
|
LGTM. if tests pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sayan Chowdhury [email protected]