This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
tests: Fix the tests for the broken links #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayan Chowdhury <[email protected]>
sayanchowdhury
force-pushed
the
updates-tests-n-cassettes
branch
from
1997229 to
922d308
Compare
sinnykumari
reviewed
Jul 25, 2018
| @@ -465,4 +465,84 @@ interactions: | |||
| x-frame-options: [SAMEORIGIN] | |||
| x-xss-protection: [1; mode=block] | |||
| status: {code: 404, message: Not Found} | |||
| - request: | |||
| body: null | |||
| headers: | |||
There was a problem hiding this comment.
I am not much familiar with this test. Can you please explain what we are testing here and from where are we getting below data?
There was a problem hiding this comment.
@sinnykumari this is generated by vcrpy it allows to record http request. The first time the tests are run the requests is recorded into this file. Next time this test will be run it will use this file to mock the request instead of making a real call.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sayan Chowdhury [email protected]