This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Drop the 'os' and 'ver' from the configuration file. Related to #46 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me but I don't know what is the idea here. |
|
I have synced the config file with the file in the infra ansible repo. Right now we maintain both the configuration https://github.com/fedora-infra/fedimg/blob/develop/fedimg/services/ec2.py#L98, so it's better if we drop the old configuration. |
|
Hm now the patch seems unrelated to the title of the PR :( |
sayanchowdhury
force-pushed
the
change-config
branch
from
6541220 to
985f9d8
Compare
|
👍 for me |
|
Thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.