This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
Make the snapshots public so that AMIs can be copied to different accounts #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounts Signed-off-by: Sayan Chowdhury <[email protected]>
|
@sayanchowdhury LGTM - is there someplace we can run this and verify the created AMI has proper perms? |
|
Going on ahead with merge 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues, BZ[1], Pagure[2] and uses the libcloud patch[3].
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1423753
[2] https://pagure.io/atomic-wg/issue/263
[3] apache/libcloud#990
/cc @dustymabe
Signed-off-by: Sayan Chowdhury [email protected]