Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

scripts: Fix the manual upload trigger script #67

Conversation

sayanchowdhury
Copy link
Contributor

Signed-off-by: Sayan Chowdhury [email protected]

Copy link

@bowlofeggs bowlofeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend raising the X bit of the version since this breaks backwards compatibility.

@bowlofeggs
Copy link

I also recommend adding tests for this change.

@sayanchowdhury sayanchowdhury force-pushed the hotfix/fix-upload-trigger-script branch from 3c55b03 to 7bdd06f Compare March 20, 2018 10:49
@sayanchowdhury
Copy link
Contributor Author

@bowlofeggs thanks, yes! the whole of fedimg needs tests right now! I am working on the tests.

@sayanchowdhury sayanchowdhury merged commit 46fba75 into fedora-infra:develop Mar 20, 2018
@sayanchowdhury sayanchowdhury deleted the hotfix/fix-upload-trigger-script branch March 20, 2018 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants