This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
services.ec2: Send a image.upload message when completed #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
reviewed
Apr 13, 2018
| @@ -192,6 +192,22 @@ def publish_images(self, region_image_mapping=None): | |||
| ) | |||
| ) | |||
|
|
|||
| fedimg.messenger.notify( | |||
| topic='image.upload', | |||
There was a problem hiding this comment.
what's the difference between image.upload and image.publish?
There was a problem hiding this comment.
None, this part was added in order for get_ami.py to work. I'll update the get_ami script and deprecate this part of code.
|
one question above ^^ LGTM |
Signed-off-by: Sayan Chowdhury <[email protected]>
sayanchowdhury
force-pushed
the
hotfix/add-new-topic-when-published
branch
from
797f497 to
6ac9122
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sayan Chowdhury [email protected]