Changed logger to use module name #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #479 +/- ##
========================================
Coverage 58.82% 58.82%
========================================
Files 29 29
Lines 1831 1831
Branches 303 303
========================================
Hits 1077 1077
Misses 667 667
Partials 87 87
Continue to review full report at Codecov.
|
bowlofeggs
approved these changes
Sep 8, 2017
| @@ -38,5 +38,5 @@ def __init__(self, hub): | |||
|
|
|||
| def consume(self, msg): | |||
| # Do nothing. | |||
| log = logging.getLogger("moksha.hub") | |||
| log = logging.getLogger(__name__) | |||
|
Thanks @Chaiku! Normally I require 100% diff coverage, but in this case I think it's a pretty safe change and the coverage isn't going down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change with reference to Issue #441