Alter how the tests determine if cryptography is available #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than re-importing cryptography and m2crypto to detect what tests to run in the test module, just import from the x509_ng module. This fixes issues when running the tests with an old pyOpenSSL library that doesn't provide the APIs we need. Signed-off-by: Jeremy Cline <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #482 +/- ##
========================================
Coverage 58.82% 58.82%
========================================
Files 29 29
Lines 1831 1831
Branches 303 303
========================================
Hits 1077 1077
Misses 667 667
Partials 87 87Continue to review full report at Codecov.
|
|
Looks find to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than re-importing cryptography and m2crypto to detect what tests
to run in the test module, just import from the x509_ng module. This
fixes issues when running the tests with an old pyOpenSSL library that
doesn't provide the APIs we need.
Signed-off-by: Jeremy Cline [email protected]