Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #533

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Fix tests #533

merged 1 commit into from
Feb 14, 2023

Conversation

Zlopez
Copy link
Collaborator

@Zlopez Zlopez commented Feb 10, 2023

This fixes tests for fedmsg.

  • Fixes docs tox env
  • Fixes lint errors

Signed-off-by: Michal Konečný [email protected]

This fixes tests for fedmsg.

* Fixes docs tox env
* Fixes lint errors

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez
Copy link
Collaborator Author

Zlopez commented Feb 10, 2023

I wasn't able to fix python 3.6 and python 2.7 tests.
Python 2.7 tests are failing on import error, which I couldn't figure out how to fix

tox/py27/lib/python2.7/site-packages/py/_path/local.py:704: in pyimport
    __import__(modname)
fedmsg/__init__.py:91: in <module>                                                                                     
    @API_function(doc=fedmsg.core.FedMsgContext.publish.__doc__)   
E   AttributeError: 'module' object has no attribute 'core'        

Python 3.6 is failing on very strange errors (empty body of messages), but because the production machine is RHEL 7 with python 2.7.5 I didn't even tried to fix them, so I don't break something on python 2.7, which I couldn't test

@Zlopez Zlopez merged commit 8261004 into fedora-infra:develop Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant