Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint *.fmf files #77

Closed
kwk opened this issue Oct 25, 2023 · 4 comments · Fixed by #502
Closed

Lint *.fmf files #77

kwk opened this issue Oct 25, 2023 · 4 comments · Fixed by #502
Assignees
@kwk
Labels
tests
Milestone
Test Snapshots wi...

Comments

@kwk
Copy link
Collaborator

kwk commented Oct 25, 2023 •
edited
Loading

On every PR we should run something like tmt lint to check for correctness of *.fmf files.

@jchecahi, is there some github action that does this or shall we write our own workflow with a fedora container and tmt installed from psss/tmt copr?

Documentation: https://tmt.readthedocs.io/en/latest/spec.html
@kwk kwk added the tests label Oct 25, 2023
@kwk
Copy link
Collaborator Author

kwk commented Oct 25, 2023

This relates to #59

@jchecahi
Copy link
Contributor

@kwk I'm not aware of any specific github action which runs tmt lint. However, and provided you already have set a pre-commit hook to lint the plans, you might want to set up a pre-commit action to be run on each PR.

TMT project itself lint their fmf files this way, check their action config.

@kwk kwk added this to the Test Snapshots with TMT milestone Nov 8, 2023
@kwk
Copy link
Collaborator Author

kwk commented Nov 8, 2023

We now have a pre-commit setup in place: https://github.com/kwk/llvm-daily-fedora-rpms/blob/main/.pre-commit-config.yaml#L12-L16.

@kwk kwk closed this as completed Nov 8, 2023
@kwk
Copy link
Collaborator Author

kwk commented Nov 8, 2023

Oh, this was for the CI site of things not just pre-commit.

@kwk kwk reopened this Nov 8, 2023
@kwk kwk self-assigned this May 22, 2024
kwk added a commit that referenced this issue May 22, 2024
@kwk
Add a pre-commit workflow
840de9b 
This runs all the checks we run locally for pre-commit but on github.
Thereby we also run tmt linting.

Fixes #77
@kwk kwk mentioned this issue May 22, 2024
Merged
@kwk kwk closed this as completed in #502 May 22, 2024
kwk added a commit that referenced this issue May 22, 2024
@kwk
Add a pre-commit workflow
2a941a1 
This runs all the checks we run locally for pre-commit but on github.
Thereby we also run tmt linting.

Fixes #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwk kwk

Labels
tests
Projects
None yet
Milestone
Test Snapshots with TMT
Development

Successfully merging a pull request may close this issue.

Add a pre-commit workflow fedora-llvm-team/llvm-snapshots
2 participants
@kwk @jchecahi