Convert to GitHub Actions #112
Conversation
.github/workflows/ci.yml
Outdated
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| bundler-cache: true | ||
| - run: bundle exec rake |
There was a problem hiding this comment.
Is there a reason to use Bundler here?
There was a problem hiding this comment.
Mostly because it's what I'm used to. Another benefit is that the GitHub action creates a cache for the next CI run. It integrates nicely with the Gemfile. Note I had to add rake there since it wasn't present in Ruby >= 2.3 (IIRC, could be 2.4).
There was a problem hiding this comment.
I think that Bundler was always used for installation, but never for execution. Using Bundler has possibly some side effects and I'd like to avoid it.
Also, as far as I can tell, Rake was first included as a bundled gem in Ruby 2.3 [1], but prior that, it was part of StdLib. Therefore I think that if Bundler is not used for execution, we should be fine without it being specified in Gemfile (and these are the side effect of Bundler and why I don't think Bundler should be used for test suite execution).
There was a problem hiding this comment.
https://github.com/ekohl/gem2rpm/actions/runs/2628516915 is the new run. I wonder why Ruby 2.6 failed.
There was a problem hiding this comment.
Ok, I guess it was just an odd issue because when I reran it it passed: https://github.com/ekohl/gem2rpm/actions/runs/2628526691
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| bundler-cache: true |
There was a problem hiding this comment.
You'd have to use the github cache action as well for persisting the cache across runs, right?
There was a problem hiding this comment.
This is all built into the ruby/setup-ruby action. See https://github.com/ruby/setup-ruby#caching-bundle-install-automatically for the details.
There was a problem hiding this comment.
Ah, TIL! Thanks for the info @ekohl!
ekohl
force-pushed
the
convert-to-gha
branch
2 times, most recently
from
d42b1db to
6a96dbc
Compare
|
Merged. Thx for the PR. It should help with the others 🎉 |
Tests ran @ https://github.com/ekohl/gem2rpm/runs/7203637950?check_suite_focus=true but they won't run as CI until this is merged.