Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fstab generator dac_read_search capability #2136

Closed
wants to merge 1 commit into from

Conversation

zpytela
Copy link
Contributor

@zpytela zpytela commented May 27, 2024

The dac_override capability has already been allowed, so it makes sense to allow dac_read_search, too, as the latter one is actually the first one checked by kernel.

Copy link

Cockpit tests failed for commit 830b0d2. @martinpitt, @jelly, @mvollmer please check.

Copy link

Cockpit tests failed for commit e1e3db2. @martinpitt, @jelly, @mvollmer please check.

@martinpitt
Copy link
Contributor

The Cockpit tests started to fail due to a tricky udisks2 regression in rawhide. We are investigating in cockpit-project/cockpit#20520 ASAP. In the meantime, please ignore the TestStorageAnaconda failures. Sorry for the noise!

@martinpitt
Copy link
Contributor

What an odyssey -- we finally found the root cause and worked around it. @zpytela I restarted the failing tests in the recent PRs.

@martinpitt
Copy link
Contributor

ah dang -- needs #2138 first, as I also reorganized the test plans. After that lands, I'll re-run all the failed PRs.

The dac_override capability has already been allowed, so it makes
sense to allow dac_read_search, too, as the latter one is actually
the first one checked by kernel.

The commit addresses the following AVC denial:
type=AVC msg=audit(1716307981.986:354): avc:  denied  { dac_read_search } for  pid=12422 comm="systemd-fstab-g" capability=2  scontext=system_u:system_r:systemd_fstab_generator_t:s0 tcontext=system_u:system_r:systemd_fstab_generator_t:s0 tclass=capability permissive=0
@zpytela
Copy link
Contributor Author

zpytela commented May 30, 2024

Addressed by #2136

@zpytela zpytela closed this May 30, 2024
@zpytela zpytela deleted the sd-fstab-gen branch May 30, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants