Updated Domestic/Foreign toggle to affect summary results #30
Conversation
…f letters in "<strong>"
…autocomplete locations
| @@ -51,7 +51,7 @@ export default class LocationList extends Typeahead { | |||
| this.typeahead.list = this.props.autocompleteLocations; | |||
|
|
|||
| this.props.autocompleteLocations.forEach((value) => { | |||
| let key = `<strong>${value.place}</strong><br>${_.upperCase(value.place_type)}`; | |||
| let key = `<b>${value.place}</b><br>${_.upperCase(value.place_type)}`; | |||
There was a problem hiding this comment.
I think we need to approach this a different way than having HTML in the autocomplete list:
There was a problem hiding this comment.
There was a problem hiding this comment.
Addressing this in a new story, since this will affect several filters
| @@ -14,7 +14,8 @@ const initialState = { | |||
| timePeriodFY: new Set(), | |||
| timePeriodStart: null, | |||
| timePeriodEnd: null, | |||
| selectedLocations: new Set() | |||
| selectedLocations: new Set(), | |||
| locationDomesticForeign: '' | |||
There was a problem hiding this comment.
Should the default be all?
There was a problem hiding this comment.
Yep, added
| {selectedLocations} | ||
| </div> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export default connect( |
There was a problem hiding this comment.
This is now a container, not a component. The container-related code (anything that has to do with API calls or manipulating data that's not directly display-related) needs to be moved to its parent container (LocationSearchContainer). Components are not allowed to be connected to Redux directly.
Please refactor.
There was a problem hiding this comment.
Moved this all back to LocationListContainer
| super(props); | ||
|
|
||
| this.state = { | ||
| locationOption: 'all', |
There was a problem hiding this comment.
Since Redux now tracks the locationDomesticForeign value, the autocomplete location scope should be controlled by Redux (ie, read from the props, write via the action rather than maintain its own state).
| placeHolder="State, City, County, ZIP, or District" | ||
| ref={(input) => { | ||
| this.locationList = input; | ||
| }} /> | ||
| ); | ||
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Why has this container been disconnected from Redux? If a container is no longer required, delete the entire file and just use the child component. However, remember that components should be dumb, in other words they do not directly make API calls, they only perform logic related to display and layout.
There was a problem hiding this comment.
Moved Redux implementation back to this container
… radio button labels, handled country selection toggle completely through Redux instead of a component state, set default option for locationDomesticForeign
No description provided.