Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raincatcher documentation #18

Merged
merged 5 commits into from
Sep 11, 2017
Merged

Update raincatcher documentation #18

merged 5 commits into from
Sep 11, 2017

Conversation

wtrocki
Copy link
Member

@wtrocki wtrocki commented Sep 7, 2017

Motivation

Update RainCatcher chapter - point to our website and updated documentation.

Udate on feedhenry.org page to no longer list our modules (it will just point to our webpage with documentation

@wtrocki wtrocki requested a review from bofarrell September 7, 2017 11:44
@wtrocki
Copy link
Member Author

wtrocki commented Sep 7, 2017

Build is failing due to external links from other content/

Copy link
Member

@austincunningham austincunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Raincatcher logo is a dead link.

@wtrocki
Copy link
Member Author

wtrocki commented Sep 7, 2017

@austincunningham This will be rendered and will work in the website. Preview will not work.
I did not changed that and it works on current website.

@wtrocki
Copy link
Member Author

wtrocki commented Sep 7, 2017

@secondsun - it looks like build is failing due to some unrelated issues with links not being available. Can I remove this links?

@secondsun
Copy link
Contributor

Try this first : gjtorikian/html-proofer#376 (comment)

Looks like Travis has outdated certs.

@wtrocki
Copy link
Member Author

wtrocki commented Sep 8, 2017

@JameelB can you take look on this?

@secondsun
Copy link
Contributor

@wtrocki I'm fine with either removing the links or adding them to a whitelist. It sounded like from the issue that updating Ubuntu would work but it does not and it isn't that important.

Copy link

@witmicko witmicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@wtrocki wtrocki merged commit c0c6a82 into master Sep 11, 2017
@wtrocki wtrocki deleted the update-raincatcher-docs branch September 11, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants