Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library: remove model protocol usage #771

Merged
merged 6 commits into from
Jan 20, 2024
Merged

library: remove model protocol usage #771

merged 6 commits into from
Jan 20, 2024

Conversation

cosven
Copy link
Member

@cosven cosven commented Jan 20, 2024 •
edited
Loading

  • NormalModel inherits BriefXModel
  • do not use model_protocol in feeluown (some plugins still use it)
  • add type hint for related API
  • enable mypy check (failed)

@coveralls
Copy link

coveralls commented Jan 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7592942144

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 55.238%
Totals Coverage Status
Change from base Build 7584684522: 0.02%
Covered Lines: 8611
Relevant Lines: 15589
💛 - Coveralls

@cosven cosven changed the title library: remove model protocol library: remove model protocol usage Jan 20, 2024
@cosven cosven mentioned this pull request Jan 20, 2024
Closed
7 tasks
@cosven cosven merged commit 356c577 into feeluown:master Jan 20, 2024
9 checks passed
@cosven cosven deleted the no-model-protocol branch January 20, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosven @coveralls