Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: add jsonrpc support for fuo server (23333) #914

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

cosven
Copy link
Member

@cosven cosven commented Feb 23, 2025

Before, only the web server(23332) supports jsonrpc.
Now, the fuo server(23333) also supports it.

Background
FeelUOwn webserver uses sanic as its web framework. However, the sanic package has many sub-dependencies. It's hard to run sanic on mobile devices such as Android.

@coveralls
Copy link

coveralls commented Feb 23, 2025

Pull Request Test Coverage Report for Build 13484934933

Details

  • 13 of 23 (56.52%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 55.88%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/webserver/server.py 0 1 0.0%
feeluown/server/handlers/handle.py 2 4 50.0%
feeluown/server/handlers/jsonrpc_.py 6 9 66.67%
feeluown/cli/cli.py 3 7 42.86%
Totals Coverage Status
Change from base Build 13437641395: 0.08%
Covered Lines: 10254
Relevant Lines: 18350

💛 - Coveralls

@cosven cosven merged commit 22167b8 into feeluown:master Feb 25, 2025
6 of 9 checks passed
@cosven cosven deleted the jsonrpc branch February 25, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants