-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate upstream fixes and improvements #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Duplicates DockerHub tags for ghcr.io * Adds login to GitHub Container Registry using the GITHUB_TOKEN secret. * Documentation update to reflect multi-registry publication.
Co-authored-by: Nick M. <[email protected]>
* Add instructions for cross-platform builds * Clean up shields * Clean up tables for each Docker configuration item * Add section about supported tags
This should resolve the following error: Error: Workflows triggered by Dependabot on the "push" event run with read-only access. Uploading Code Scanning results requires write access. To use Code Scanning with Dependabot, please ensure you are using the "pull_request" event for this workflow and avoid triggering on the "push" event for Dependabot branches. See https://docs.github.com/en/code-security/secure-coding/configuring-code-scanning#scanning-on-push for more information on how to configure these events.
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Nick M. <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
* Add a comment describing what the files does. * Add sections to organize patterns.
Due to her departure this removes hillaryj from the default CODEOWNERS we use in our projects.
The semver package is needed by the bump_version.sh script, but it is not included in requirements-dev.txt.
The version attribute has been depricated and will be removed once our systems move to a more recent release.
Co-authored-by: Hillary <[email protected]>
Since the GitHub Actions configuration builds images on tag pushes, we should use the standard tagging script we use for the same purpose in other repositories. This will make it easier to tag, build, and push Docker images of a specific version in a standardized manner.
Co-authored-by: Shane Frasier <[email protected]>
Hooks updated with the `pre-commit autoupdate` command. Note: The `ansible-lint` hook is intentionally being held back on 4.3.7 because of ongoing issues with the 5.x version and how we use Ansible (standalone Galaxy roles).
With the release of pyenv v2.0.0 there is a breaking change around startup logic that necessitates an update for our pyenv setup instructions. Also add a statement about how to get configuration instructions from pyenv itself.
Update pre-commit Hooks
…owners Remove User from CODEOWNERS
…ctions Update Instructions for Configuring pyenv
Change from using an environment variable to the outputs of the cisagov/setup-env-github-action instead.
We use a `PACKER_VERSION` environment variable for the "Install Packer" step that is populated from the `setup-env` outputs to get around `yamllint` lint length limits.
We change the "Install shfmt" step to use two local environment variables to provide the package's URL and version to install. This allows us to work around `yamllint` line length limits.
We change the "Install Terraform-docs" step to use two local environment variables to provide the package's URL and version to install. This allows us to work around `yamllint` line length limits.
This changes from using an environment variable to using a step output to store the Go version that is installed. This mirrors changes made to the other program versions and how they're stored.
Use Outputs of cisagov/setup-env-github-action to Control Installed Program Versions
Remove the manual exclusion of the `converge.yml` file in the default molecule scenario. With the changes in cisagov/skeleton-ansible-role#88 this exclusion is no longer necessary.
Instead of excluding molecule configurations for systemd individually we instead direct ansible-lint to process any of these configurations in scenario directories as plain yaml files. This mirrors how ansible-lint handles `molecule.yml` files in scenario directories by default.
Bumps python from 3.10.0-alpine to 3.10.1-alpine. --- updated-dependencies: - dependency-name: python dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Update pre-commit hooks using `pre-commit autoupdate`.
Update `pre-commit` hooks
…onfiguration Update `ansible-lint` Configuration
Lineage pull request for: skeleton
…lpine Bump python from 3.10.0-alpine to 3.10.1-alpine
…/github-script-5 Bump actions/github-script from 4 to 5
…rovement/upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
💭 Motivation and Context
🧪 Testing
Locally and in CI.
✅ Checklist
the changes in this PR.