Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate upstream fixes and improvements #45

Merged
merged 155 commits into from
Jan 19, 2022
Merged

Conversation

felddy
Copy link
Owner

@felddy felddy commented Jan 19, 2022

🗣 Description

  • Merge in changes from upstream skeleton to correct errors in nightly builds.
  • Pin Docker images more tightly.

💭 Motivation and Context

  • Fixing bit rot.
  • Future-proofing.

🧪 Testing

Locally and in CI.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow project standards.
  • All relevant repo and/or project documentation has been updated to reflect
    the changes in this PR.
  • All new and existing tests pass.

felddy and others added 30 commits March 25, 2021 17:37
* Duplicates DockerHub tags for ghcr.io
* Adds login to GitHub Container Registry using the GITHUB_TOKEN secret.
* Documentation update to reflect multi-registry publication.
* Add instructions for cross-platform builds
* Clean up shields
* Clean up tables for each Docker configuration item
* Add section about supported tags
This should resolve the following error:

Error: Workflows triggered by Dependabot on the "push" event run with read-only
access. Uploading Code Scanning results requires write access. To use Code
Scanning with Dependabot, please ensure you are using the "pull_request" event
for this workflow and avoid triggering on the "push" event for Dependabot
branches. See
https://docs.github.com/en/code-security/secure-coding/configuring-code-scanning#scanning-on-push
for more information on how to configure these events.
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Nick M. <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
Co-authored-by: Hillary <[email protected]>
* Add a comment describing what the files does.
* Add sections to organize patterns.
Due to her departure this removes hillaryj from the default CODEOWNERS we use
in our projects.
The semver package is needed by the bump_version.sh script, but it is not
included in requirements-dev.txt.
The version attribute has been depricated and will be removed once our 
systems move to a more recent release.
Co-authored-by: Hillary <[email protected]>
Since the GitHub Actions configuration builds images on tag pushes, we should
use the standard tagging script we use for the same purpose in other
repositories. This will make it easier to tag, build, and push Docker images
of a specific version in a standardized manner.
Co-authored-by: Shane Frasier <[email protected]>
Hooks updated with the `pre-commit autoupdate` command.

Note:
The `ansible-lint` hook is intentionally being held back on 4.3.7 because of
ongoing issues with the 5.x version and how we use Ansible (standalone Galaxy
roles).
With the release of pyenv v2.0.0 there is a breaking change around startup
logic that necessitates an update for our pyenv setup instructions. Also
add a statement about how to get configuration instructions from pyenv
itself.
…ctions

Update Instructions for Configuring pyenv
mcdonnnj and others added 22 commits October 19, 2021 17:51
Change from using an environment variable to the outputs of the
cisagov/setup-env-github-action instead.
We use a `PACKER_VERSION` environment variable for the "Install Packer" step
that is populated from the `setup-env` outputs to get around `yamllint` lint
length limits.
We change the "Install shfmt" step to use two local environment variables to
provide the package's URL and version to install. This allows us to work around
`yamllint` line length limits.
We change the "Install Terraform-docs" step to use two local environment
variables to provide the package's URL and version to install. This allows us
to work around `yamllint` line length limits.
This changes from using an environment variable to using a step output to store
the Go version that is installed. This mirrors changes made to the other
program versions and how they're stored.
Use Outputs of cisagov/setup-env-github-action to Control Installed Program Versions
Remove the manual exclusion of the `converge.yml` file in the default molecule
scenario. With the changes in cisagov/skeleton-ansible-role#88 this exclusion
is no longer necessary.
Instead of excluding molecule configurations for systemd individually we
instead direct ansible-lint to process any of these configurations in
scenario directories as plain yaml files. This mirrors how ansible-lint
handles `molecule.yml` files in scenario directories by default.
Bumps python from 3.10.0-alpine to 3.10.1-alpine.

---
updated-dependencies:
- dependency-name: python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Update pre-commit hooks using `pre-commit autoupdate`.
…onfiguration

Update `ansible-lint` Configuration
Lineage pull request for: skeleton
…lpine

Bump python from 3.10.0-alpine to 3.10.1-alpine
…/github-script-5

Bump actions/github-script from 4 to 5
@felddy felddy self-assigned this Jan 19, 2022
@felddy felddy merged commit b3b459c into develop Jan 19, 2022
@felddy felddy deleted the improvement/upstream branch January 19, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants