Favorite #90
Merged
Favorite #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agazso
reviewed
Dec 21, 2018
…d other style fixes
…in the store filter posts to only show followed=false posts when having a feed opened directly
|
@agazso Added some changes we have discussed, please try how it works for you now. There are some code quality issues left, imho does should be addressed outside this pr. |
agazso
reviewed
Dec 29, 2018
agazso
reviewed
Dec 29, 2018
agazso
reviewed
Dec 29, 2018
agazso
reviewed
Dec 29, 2018
Merged
agazso
reviewed
Dec 30, 2018
agazso
reviewed
Dec 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because how I changed the UI I decided to add a 'refollow' feature which escalated a bit :-)
I added to the state the visitedFeeds. Originally I wanted something for storing unfollowed feeds, but I realized we will want to open feeds without following them explicitly, hence the naming.
One thing is stil missing (if I'm not mistaken), removing the posts from unfollowed feed, when navigating away.