Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticlv5: additional changes concerning timing and linking #24

Merged
merged 9 commits into from
Feb 20, 2024
Merged

Ticlv5: additional changes concerning timing and linking #24

merged 9 commits into from
Feb 20, 2024

Conversation

AuroraPerego
Copy link

  • the combination of HGCAL and ETL time is done in the TICLCandidateProducer instead of PFTICLProducer
  • ETL time quality with MVA is used w/ a threshold of 0.5
  • tracker muons (seeded from the tracker and little activity in the muon chambers) are considered for the linking and create muon candidates only if they have not been linked and are global muons
  • created MTD SoA to store timing info in a single collection
  • ETL time stored in candidates

TODO:

  • when MTD associators will be available, check if there is a reco cluster associated with the sim before assigning ETL true time to simTICLCandidates
  • after 14_0_0_pre3 use PortableHostCollectionReadRules in classes.cc for the SoA instead of declaring the rules in the classes_def.xml

@felicepantaleo felicepantaleo merged commit 280c68e into felicepantaleo:ticlv5_14_0_0_pre0 Feb 20, 2024
felicepantaleo pushed a commit that referenced this pull request Apr 18, 2024
@AuroraPerego @felicepantaleo
[ticlv5] additional changes concerning timing and linking (#24)
8408cf1 
* ticlv5: use quality in time compatibility and move combination of HGCAL and MTD time in the TICLCandidateProducer

* ticlv5: fix comments

* ticlv5: consider trackerMuon for linking

- new PFTICLProducer for timing and muons

* ticlv5: add SoA for MTD info (NOTE: use PortableHostCollectionReadRules when available --> pre3)

* ticlv5: use the MTD SoA in the TICLCandidate producer

* ticlv5: add ETL time to candidates

* code checks and code format

* ticlv5: fix when MTD timing is not used

* ticlv5: fix validation plots
felicepantaleo pushed a commit that referenced this pull request Apr 19, 2024
@AuroraPerego @felicepantaleo
[ticlv5] additional changes concerning timing and linking (#24)
9403b79 
* ticlv5: use quality in time compatibility and move combination of HGCAL and MTD time in the TICLCandidateProducer

* ticlv5: fix comments

* ticlv5: consider trackerMuon for linking

- new PFTICLProducer for timing and muons

* ticlv5: add SoA for MTD info (NOTE: use PortableHostCollectionReadRules when available --> pre3)

* ticlv5: use the MTD SoA in the TICLCandidate producer

* ticlv5: add ETL time to candidates

* code checks and code format

* ticlv5: fix when MTD timing is not used

* ticlv5: fix validation plots
felicepantaleo pushed a commit that referenced this pull request Apr 19, 2024
@AuroraPerego @felicepantaleo
[ticlv5] additional changes concerning timing and linking (#24)
b7339f7 
* ticlv5: use quality in time compatibility and move combination of HGCAL and MTD time in the TICLCandidateProducer

* ticlv5: fix comments

* ticlv5: consider trackerMuon for linking

- new PFTICLProducer for timing and muons

* ticlv5: add SoA for MTD info (NOTE: use PortableHostCollectionReadRules when available --> pre3)

* ticlv5: use the MTD SoA in the TICLCandidate producer

* ticlv5: add ETL time to candidates

* code checks and code format

* ticlv5: fix when MTD timing is not used

* ticlv5: fix validation plots
felicepantaleo pushed a commit that referenced this pull request May 2, 2024
@AuroraPerego @felicepantaleo
[ticlv5] additional changes concerning timing and linking (#24)
f79301d 
* ticlv5: use quality in time compatibility and move combination of HGCAL and MTD time in the TICLCandidateProducer

* ticlv5: fix comments

* ticlv5: consider trackerMuon for linking

- new PFTICLProducer for timing and muons

* ticlv5: add SoA for MTD info (NOTE: use PortableHostCollectionReadRules when available --> pre3)

* ticlv5: use the MTD SoA in the TICLCandidate producer

* ticlv5: add ETL time to candidates

* code checks and code format

* ticlv5: fix when MTD timing is not used

* ticlv5: fix validation plots
felicepantaleo pushed a commit that referenced this pull request May 30, 2024
@AuroraPerego @felicepantaleo
[ticlv5] additional changes concerning timing and linking (#24)
60d46b5 
* ticlv5: use quality in time compatibility and move combination of HGCAL and MTD time in the TICLCandidateProducer

* ticlv5: fix comments

* ticlv5: consider trackerMuon for linking

- new PFTICLProducer for timing and muons

* ticlv5: add SoA for MTD info (NOTE: use PortableHostCollectionReadRules when available --> pre3)

* ticlv5: use the MTD SoA in the TICLCandidate producer

* ticlv5: add ETL time to candidates

* code checks and code format

* ticlv5: fix when MTD timing is not used

* ticlv5: fix validation plots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AuroraPerego @felicepantaleo