Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InkWell requires TextFieldTapRegion for onTap suggestion to work #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bZichett
Copy link

Similar to the problem this repository had, this library stopped working with flutter 3.7:

AbdulRahmanAlHamali/flutter_typeahead@7a6f333

@bZichett
Copy link
Author

Note: I tested on flutter 3.7 but not with < 3.7. Probably worth it to check that as well but I'd have to reinstall the old one so I held off.

@bZichett
Copy link
Author

Additional note: I prefer the features / syntax for this library rather than https://api.flutter.dev/flutter/material/Autocomplete-class.html so would be neat to get this working again. In the meantime, I am able to just patch the external library after its downloaded in my main project. (Others can do the same)

@pbruins84
Copy link

This is a great fix!

@bZichett
Copy link
Author

bZichett commented May 12, 2023

@pbruins84 Thanks. But since this hasnt been merged, I suggest using native flutter widget class Autocomplete @ https://api.flutter.dev/flutter/material/Autocomplete-class.html.

Relatively to easy to convert and covers most use cases at this point and less susceptible to future breakage (was able to get equivalence and cut out an external non-built in dependency.) Let me know if you cant get it working 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants