Skip to content

Commit

Permalink
Fixup behavior and styling of editor re-auth.
Browse files Browse the repository at this point in the history
Closes TryGhost#2092
- Adds styling for re-auth modal.
- Prevent transition to posts route on success.
- Clear credentials from controller.
- Handle confirmAccept action if form is submitted via 'enter'.
- Only allow re-auth as the user that was previously logged in.
  • Loading branch information
jaswilli committed Dec 15, 2014
1 parent 1961b07 commit 1541b92
Show file tree
Hide file tree
Showing 5 changed files with 72 additions and 16 deletions.
37 changes: 36 additions & 1 deletion core/client/assets/sass/components/modals.scss
Original file line number Diff line number Diff line change
Expand Up @@ -165,4 +165,39 @@

.modal-style-centered {
text-align: center;
}
}

// Modal login styles
.modal-body .login-form {
display: block; // Override inherited `display: table-cell;`

.password-wrap {
input {
width: 100%;
}
}

@media (max-width: 900px) {
margin: 0 auto;
max-width: 264px;

.password-wrap {
width: 100%;
margin: 0 auto 1em;
}

.btn {
margin: 0;
width: 100%;
margin-bottom: 1em;
}
}

@media (min-width: 901px) {
display: flex;

.password-wrap {
flex: 1;
}
}
}
26 changes: 22 additions & 4 deletions core/client/controllers/modals/signin.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,30 @@
import SigninController from '../signin';
import SigninController from 'ghost/controllers/signin';

export default SigninController.extend({
needs: 'application',

identification: Ember.computed('session.user.email', function () {
return this.get('session.user.email');
}),

actions: {
authenticate: function (data) {
var self = this;
this._super(data).then(function () {
authenticate: function () {
var appController = this.get('controllers.application'),
self = this;

appController.set('skipAuthSuccessHandler', true);

this._super().then(function () {
self.send('closeModal');
self.notifications.showSuccess('Login successful.');
self.set('password', '');
}).finally(function () {
appController.set('skipAuthSuccessHandler', undefined);
});
},

confirmAccept: function () {
this.send('validateAndAuthenticate');
}
}
});
6 changes: 3 additions & 3 deletions core/client/initializers/authentication.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ AuthenticationInitializer = {

window.ENV['simple-auth'] = {
authenticationRoute: 'signin',
routeAfterAuthentication: 'content',
routeAfterAuthentication: 'posts',
authorizer: 'simple-auth-authorizer:oauth2-bearer',
localStorageKey: 'ghost' + (Ghost.subdir.indexOf('/') === 0 ? '-' + Ghost.subdir.substr(1) : '') + ':session'
};
Expand All @@ -27,9 +27,9 @@ AuthenticationInitializer = {
};

SimpleAuth.Session.reopen({
user: function () {
user: Ember.computed(function () {
return container.lookup('store:main').find('user', 'me');
}).property()
})
});

SimpleAuth.Authenticators.OAuth2.reopen({
Expand Down
8 changes: 7 additions & 1 deletion core/client/routes/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,13 @@ ApplicationRoute = Ember.Route.extend(SimpleAuth.ApplicationRouteMixin, Shortcut
},

sessionAuthenticationSucceeded: function () {
var self = this;
var appController = this.controllerFor('application'),
self = this;

if (appController && appController.get('skipAuthSuccessHandler')) {
return;
}

this.store.find('user', 'me').then(function (user) {
self.send('signedIn', user);
var attemptedTransition = self.get('session').get('attemptedTransition');
Expand Down
11 changes: 4 additions & 7 deletions core/client/templates/modals/signin.hbs
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
{{#gh-modal-dialog action="closeModal" showClose=true type="action" style="wide,centered" animation="fade"
title="Please login again" confirm=confirm}}
{{#gh-modal-dialog action="closeModal" showClose=true type="action" style="wide" animation="fade"
title="Please re-authenticate" confirm=confirm}}

<form id="login" class="login-form" method="post" novalidate="novalidate" {{action 'validateAndAuthenticate' on='submit'}}>
<div class="email-wrap">
{{input class="email" type="email" placeholder="Email Address" name="identification" autofocus="autofocus" autocapitalize="off" autocorrect="off" value=identification}}
</div>
<form id="login" class="login-form" method="post" novalidate="novalidate" {{action "validateAndAuthenticate" on="submit"}}>
<div class="password-wrap">
{{input class="password" type="password" placeholder="Password" name="password" value=password}}
</div>
<button class="button-save" type="submit" {{action "validateAndAuthenticate"}} {{bind-attr disabled=submitting}}>Log in</button>
<button class="btn btn-blue" type="submit" {{action "validateAndAuthenticate"}} {{bind-attr disabled=submitting}}>Log in</button>
</form>

{{/gh-modal-dialog}}

0 comments on commit 1541b92

Please sign in to comment.