Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manifest): support kebab case labels #2300

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix(manifest): support kebab case labels #2300

merged 1 commit into from
Feb 27, 2024

Conversation

kate-goldenring
Copy link
Contributor

fixes #2278

itowlson
itowlson reviewed Feb 27, 2024
View reviewed changes
crates/manifest/src/schema/v2.rs Outdated Show resolved Hide resolved
crates/manifest/src/schema/v2.rs Show resolved Hide resolved
itowlson
itowlson approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions on the testing but otherwise LGTM (and those are not blockers). Thanks for catching and addressing this!

crates/manifest/src/schema/v2.rs Outdated Show resolved Hide resolved
crates/manifest/src/schema/v2.rs Outdated Show resolved Hide resolved
@kate-goldenring kate-goldenring merged commit 4cfbac6 into fermyon:main Feb 27, 2024
10 checks passed
@kate-goldenring kate-goldenring deleted the kebab-case-labels branch February 27, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itowlson itowlson itowlson approved these changes

@lann lann Awaiting requested review from lann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different label naming conventions for KV stores vs AI models
3 participants
@kate-goldenring @lann @itowlson