generate StrEnum for python 3.11+ #4090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
reviewed
Jul 22, 2024
| name=self._get_class_name(), | ||
| extends=[ | ||
| # If using python 3.11+, generate classes with StrEnum instead of (str, Enum) | ||
| if sys.version_info >= (3, 11): |
There was a problem hiding this comment.
why? that already sets up the pyproject.toml -- does that not determine the env that the generator runs in? Happy to plumb it but it doesn't quite feel right to me since that config is a version string for a solver, not true version info
There was a problem hiding this comment.
ugh I see that's just for the generated project... will this even work if the generator is running via 3.9? I'm not sure how the reference imports work (if it's just straight up string concat or not) but StrEnum isn't in the stdlib until 3.11 so if it relies on the presence of the thing we're kinda SOL
jochs
force-pushed
the
jow/python-3.11-enum-compat
branch
from
8982460 to
8905822
Compare
jochs
force-pushed
the
jow/python-3.11-enum-compat
branch
from
ebb3f1d to
5a6bfc6
Compare
jochs
force-pushed
the
jow/python-3.11-enum-compat
branch
from
5a6bfc6 to
6b40950
Compare
jochs
force-pushed
the
jow/python-3.11-enum-compat
branch
from
94b1877 to
005bf26
Compare
dsinghvi
force-pushed
the
main
branch
11 times, most recently
from
4eb9f86 to
9180bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(str, Enum) mixins have undergone a breaking change in python 3.11 - see python/cpython#100458
This PR adds poetry core to the dependencies to allow for version constraint parsing, and lists an explicit set of python minor versions to allow.
The target version is the lowest version that satisfies the constraint.
Also I don't have a good way to generate the lockfiles with poetry 1.7, so if somebody could regenerate them for me that'd be appreciated