feat(python): Support Adding Statements to Classes and Methods #4949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvargas92495
approved these changes
Oct 18, 2024
|
|
||
| exports[`class > should generate a class with local classes 1`] = ` | ||
| "class OuterClass: | ||
| class InnerClass(ParentClass): |
There was a problem hiding this comment.
[q] where does ParentClass come from? Are we missing an import statement, or is that oos for this PR?
There was a problem hiding this comment.
Imports only get resolved within the context of a PythonFile being written.
dsinghvi
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, we can now add statements to classes and methods in the python ast.