Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Support overriding default dev dependencies and mypy config in the python generator #5062

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dvargas92495
Copy link
Collaborator

We want to use mypy 1.11.1 in our sdk development. This allows us to specify it here

@coderabbitai summary

Copy link

github-actions bot commented Nov 1, 2024

@dvargas92495 dvargas92495 changed the title feat(python): Support overriding default dev dependencies in the python generator feat(python): Support overriding default dev dependencies and mypy config in the python generator Nov 1, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in most of these files is mostly a side effect of dependencies now being alphabetized, which I think is likely preferable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only file here that is intended to be affected by changes is pyproject.toml. It felt overkill for all of this other stuff to be generated too

I'm also not sure if I put this fixtures in the right spot. If I need to regen elsewhere, I'd love tips on how to run just my nested fixture so that I don't have to wait ~hour for tests to run
Screenshot 2024-11-07 at 8 30 20 AM

@dvargas92495
Copy link
Collaborator Author

Confused why go-snippets would fail for python config specific tests?
Screenshot 2024-11-07 at 8 39 48 AM

@dannysheridan dannysheridan requested review from eyw520 and removed request for dsinghvi January 11, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant