feat(python): Support wrapped aliases for Pydantic v2 #5115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-giglio
changed the base branch from
main
to
dsinghvi/v2-wrapped-aliases
matthew-giglio
commented
Nov 5, 2024
| module_path=("pydantic",), | ||
| ), | ||
| ), | ||
| import_=Pydantic.PydanticImport(), |
There was a problem hiding this comment.
Added this for easier reference in other codepaths
matthew-giglio
commented
Nov 5, 2024
Comment on lines
+118
to
+126
| def _model_validator(self, pre: bool = False) -> AST.FunctionInvocation: | ||
| return AST.FunctionInvocation( | ||
| function_definition=AST.Reference( | ||
| qualified_name_excluding_import=("model_validator",), | ||
| import_=Pydantic.PydanticImport(), | ||
| ), | ||
| kwargs=[("mode", AST.Expression(expression='"before"' if pre else '"after"'))], | ||
| ) | ||
|
|
There was a problem hiding this comment.
I don't like having this as part of the class, but I also don't know where you store utility files in your repo. Feel free to move!
dsinghvi
merged commit c0409db
into
fern-api:dsinghvi/v2-wrapped-aliases
5 checks passed
dsinghvi
pushed a commit
that referenced
this pull request
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RootModelandmodel_validatoron their validatorsRootModeldoes not supportextraas a keyword nor does it supportfrozenbehavior well`, so we omit those from the model behavior here