Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csharp): Update CI workflow inside C# SDK generator #5283

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Swimburger
Copy link
Member

Description

Simplify and optimize the CI workflow & update the GH actions dependencies & use .NET 9 as the runtime host.

Changes Made

  • Merge three jobs into a single job to avoid re-do'ing the same work multiple times (installing .NET, restoring packages, building project)
  • Make sure the versions of .NET that we're compiling are installed
  • Also, install the .NET 9 SDK as the MSBuild and .NET CLI in this version have improvements even when compiling for older TFMs.
  • Break up .NET build into separate steps, each depending on the previous step
    1. Restore dependencies
    2. Build solution (without restore)
    3. Test solution (without build & without restore)
    4. Pack solution (without build & without restore), regardless of whether tests pass (as it worked previously)
  • Reducing irrelevant log output by setting DOTNET_SKIP_FIRST_TIME_EXPERIENCE and DOTNET_NOLOGO env variables
  • Update GitHub actions (actions/checkout & actions/setup-dotnet)

Since now it's a single job, the UI will look different.
If we really want the UI to show three different jobs, we can revert to three jobs, but it'll slow down the pipeline significantly without any real benefit AFAIK.

Testing

  • Manual testing completed

@Swimburger Swimburger requested a review from dsinghvi as a code owner November 26, 2024 17:14
Copy link

github-actions bot commented Nov 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant