Propose inline java types #5546
Conversation
| // Inline enums not available in Java 8 | ||
| // public enum MyEnum { | ||
| // SUNNY("Sunny"), | ||
| // CLOUDY("Cloudy"), | ||
| // RAINING("Raining"), | ||
| // SNOWING("Snowing"), | ||
| // ; | ||
| // | ||
| // private final String value; | ||
| // | ||
| // MyEnum(String value) { | ||
| // this.value = value; | ||
| // } | ||
| // | ||
| // public String toString() { | ||
| // return this.value; | ||
| // } | ||
| // } |
There was a problem hiding this comment.
I've commented this out because the IntelliJ suggestion was saying this isn't available in Java 8 (which is apparently the compile target for our seed projects by default, judging from the fact that I copied the base gradle files for this from the generated java-inline-path-params fixture). Would it be reasonable/easy to require a certain version of java for the generator if the user enables the inline types feature, just to guarantee that they have access to inline enums? If not, I can come up with a workaround. I suppose this hinges on the version of Java that Intercom users are going to use this SDK on.
There was a problem hiding this comment.
I think we'll need to support in-lined types for Java 8, so I wonder if we should continue to generate enums as long type names and in-line everything else (like it's already demonstrated here).
This is a good question for @dsinghvi, too.
There was a problem hiding this comment.
Spoke offline; it looks like Java allows us to declare enums within a top-level class but not within any deeper level of nesting. Our approach is going to be as follows;
- One PR that implements support for in-line object types and leaves enums at the top level always
- Another PR that implements support for in-line enums only if they're at the first level of nesting, and leaves them un-inlined otherwise.
This is a proposal for how we could generate inline types in the Java SDK generator, similarly to what we do in TypeScript. For more information see the ticket: https://linear.app/buildwithfern/issue/FER-3805/[intercom-java]-add-support-for-inlined-types