Make Buffer more compliant with official implementation #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@feross I know this is a small change, but this is needed to land nodejs/readable-stream#452 so your review will be very appreciated |
|
@feross Any chance you could take a look at this? :) |
|
ping @feross? :) |
addaleax
reviewed
Jun 22, 2021
| @@ -1688,7 +1688,7 @@ Buffer.prototype.writeDoubleBE = function writeDoubleBE (value, offset, noAssert | |||
|
|
|||
| // copy(targetBuffer, targetStart=0, sourceStart=0, sourceEnd=buffer.length) | |||
| Buffer.prototype.copy = function copy (target, targetStart, start, end) { | |||
| if (!Buffer.isBuffer(target)) throw new TypeError('argument should be a Buffer') | |||
| if (!Buffer.isBuffer(target) && !(target instanceof Uint8Array)) throw new TypeError('argument should be a Buffer') | |||
There was a problem hiding this comment.
It’s probably nicer to use Object.prototype.toString.call(target) === '[object Uint8Array]' here instead of instanceof, because instanceof still won’t work across multiple realms (e.g. iframes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all the instances where Uint8Array is a valid parameter but errors due to the parameter "not being a buffer"