Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript type declarations #21

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Add TypeScript type declarations #21

merged 1 commit into from
Apr 25, 2018

Conversation

ukstv
Copy link
Collaborator

@ukstv ukstv commented Apr 23, 2018 •
edited
Loading

Here is a volunteered TypeScript declaration.

@feross
Copy link
Owner

feross commented Apr 25, 2018

LGTM

@feross feross merged commit d3f0a33 into feross:master Apr 25, 2018
@feross
Copy link
Owner

feross commented Apr 25, 2018

Released as 5.1.2

@feross
Copy link
Owner

feross commented Apr 25, 2018

@ukstv Would you mind sending a similar PR for the buffer package?

@ukstv
Copy link
Collaborator Author

ukstv commented Apr 27, 2018

Ok.

@ukstv
Copy link
Collaborator Author

ukstv commented Apr 27, 2018

Super cool the declarations are released!

@ukstv
Copy link
Collaborator Author

ukstv commented Apr 27, 2018

feross/buffer#194 Here is a pull request to buffer package.

@feross
Copy link
Owner

feross commented Apr 28, 2018

Thanks @ukstv, super appreciate it! I'm going to add you as a GitHub collaborator to the safe-buffer and the buffer repo. It would be great if you could keep the TypeScript types up-to-date. There aren't that many API changes, but I imagine there may be some changes in the future.

@ukstv
Copy link
Collaborator Author

ukstv commented May 2, 2018

@feross You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukstv @feross