Fix symlink creation on Windows Issue #10 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feross
added a commit
that referenced
this pull request
Jun 10, 2015
Fix symlink creation on Windows Issue #10
|
Thanks! Released as 2.4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
On Windows 8.1 I was running in to an issue with the symbolic links created by Zelda.
Within my
node_modulesfolder<package>.symlinkfiles were being created instead of the expected folder symlinks.Doing some searching led me to nodejs/node-v0.x-archive#2274, which pointed me towards the documentation here:
https://nodejs.org/api/fs.html#fs_fs_symlink_srcpath_dstpath_type_callback
It looks like if on Windows specifying the
typeparameter'dir'tofs.symlinkSyncis necessary for the right kind of link to be created. For non-Windows platforms thistypeparameter is ignored.