Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wlroots modifier emulation support #238

Merged

Conversation

Vassili-Dev
Copy link
Contributor

Fixes #204

Change Summary:

WLRoots Emulation

  • Internally track modifier state via VirtualInput.modifiers
    • On KeyboardEvent::Key: If key matches modifiers, either depress or toggle respective mod
    • On KeyboardEvent::Modifiers: Set internal modifiers state to match the event
  • Add current time to discrete scroll event (Fixes scrolling)

@feschber
Copy link
Owner

Would you mind making the scrolling fix a separate PR?

@Vassili-Dev
Copy link
Contributor Author

Vassili-Dev commented Nov 27, 2024

Reverted the scroll change, put in separate PR

@flexd
Copy link

flexd commented Jan 7, 2025

Any chance this will be merged? :-) I would love to be able to use this with Sway

@feschber
Copy link
Owner

feschber commented Jan 7, 2025

Yeah sorry about the dealy, I'm just busy with University and other stuff atm. Will hopefully get to it this week :)

@feschber feschber force-pushed the wlroots-modifier-emulation-support branch 4 times, most recently from 85f22e9 to 54ef572 Compare January 24, 2025 14:19
@feschber feschber force-pushed the wlroots-modifier-emulation-support branch from 54ef572 to 151f681 Compare January 24, 2025 14:24
@feschber
Copy link
Owner

alright, sorry I force pushed 10 times but should be ready for merging now. I will see what I can do about the caps lock thing later

@feschber feschber merged commit beb656e into feschber:main Jan 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows -> Wayland (Sway) Modifier Keys not registering
3 participants