This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Add slashing threshold to params and evidence #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmannwong
commented
Oct 7, 2020
| func (bie *BeaconInactivityEvidence) ValidatorHeight() int64 { | ||
| return bie.AeonStart | ||
| return bie.AeonStart - 1 |
There was a problem hiding this comment.
This is a bug fix.
jinmannwong
commented
Oct 9, 2020
| @@ -346,7 +347,7 @@ message Evidence { | |||
| int64 height = 3; | |||
| google.protobuf.Timestamp time = 4 [(gogoproto.nullable) = false, (gogoproto.stdtime) = true]; | |||
| int64 total_voting_power = 5; | |||
| Validator complainant = 6; // Allowed to be null | |||
| int64 threshold = 6; | |||
There was a problem hiding this comment.
No longer need to send the validator who signed the complaint as we make the evidence from each validator each aeon unique so that duplicates can not be submitted into the blocks
n-hutton
approved these changes
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add threshold number of complaints required for slashing into evidence itself. Reason for this is because the threshold changes with the size of the validator set, which may not be the same size in every aeon