This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Separate timestamp from vote signature #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jinmannwong
commented
Oct 21, 2020
jinmannwong
commented
- Add extra timestamp signature into vote message
- Remove timestamp signature when votes are included into a block
jinmannwong
commented
Oct 21, 2020
| @@ -18,7 +18,7 @@ import ( | |||
|
|
|||
| const ( | |||
| // MaxEvidenceBytes is a maximum size of any evidence (including amino overhead). | |||
| MaxEvidenceBytes int64 = 484 | |||
| MaxEvidenceBytes int64 = 616 | |||
There was a problem hiding this comment.
Increased because votes now contain an extra signature
jinmannwong
commented
Oct 21, 2020
| @@ -64,64 +64,56 @@ func TestVoteSignBytesTestVectors(t *testing.T) { | |||
| 0: { | |||
| "", &Vote{}, | |||
| // NOTE: Height and Round are skipped here. This case needs to be considered while parsing. | |||
| []byte{0xd, 0x2a, 0xb, 0x8, 0x80, 0x92, 0xb8, 0xc3, 0x98, 0xfe, 0xff, 0xff, 0xff, 0x1}, | |||
| []byte{0x0}, | |||
There was a problem hiding this comment.
Changes because timestamp has been removed from the return of the vote SignBytes function
n-hutton
approved these changes
Oct 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.