This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

Fix race and nil return in precommits/votes #220

Merged

jinmannwong merged 4 commits into fetchai:master from jinmannwong:bug_fix/height_vote_set

Oct 29, 2020

Contributor

jinmannwong commented Oct 28, 2020 •

edited

Loading

Fix failed interface conversion from return of nil interface in height vote set getPrecommit and getPrevote
Fix race condition in getting validator set size in consensus/reactor log message. Save validator set size in creation of PrecommitRecord instead
Fix incorrect signing of votes in timestamp test

jinmannwong added 4 commits

October 28, 2020 17:42


          Bug fux on unit tests

5f56adf


          Fix race

cc9d311


          Bug fix timestamp test

63504bd


          Fix signing in test

fdd4c5a

n-hutton approved these changes

View reviewed changes

jinmannwong merged commit af5f49d into fetchai:master

jinmannwong deleted the bug_fix/height_vote_set branch

October 29, 2020 10:34

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet