Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 dockerize #15

Merged
merged 22 commits into from
Mar 7, 2018
Merged

10 dockerize #15

merged 22 commits into from
Mar 7, 2018

Conversation

fetmar
Copy link
Owner

@fetmar fetmar commented Mar 7, 2018

Issue #10

  • added dockerfile and handling restarts with pm2 inside the container
  • builds docker image in travis
  • Pushes to docker
  • Put some useful tags on the image
  • decided to npm install inside the dockerfile, because it might pick things for that environment
  • added request logging middleware
  • run with non root user
  • only push for master branch

@coveralls
Copy link

coveralls commented Mar 7, 2018

Pull Request Test Coverage Report for Build 89

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.353%

Totals Coverage Status
Change from base Build 52: 0.1%
Covered Lines: 230
Relevant Lines: 246

💛 - Coveralls

@fetmar fetmar merged commit cb1d98f into master Mar 7, 2018
@fetmar fetmar deleted the 10-dockerize branch March 7, 2018 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants