Use RON as the primary format #100

cblp · 2018-10-28T18:58:10Z

For #25

This change is

cblp

Reviewable status: 0 of 19 files reviewed, 2 unresolved discussions

a discussion (no related file):
ron-storage in separate patch

a discussion (no related file):
Types2 -> Types

cblp

Reviewable status: 0 of 19 files reviewed, 2 unresolved discussions

a discussion (no related file):

Previously, cblp (Yuriy Syrovetskiy) wrote…

ron-storage in separate patch

#101

cblp

Reviewable status: 0 of 15 files reviewed, 2 unresolved discussions

a discussion (no related file):
Remove FF.Storage

cblp

Reviewed 1 of 14 files at r4.
Reviewable status: 1 of 16 files reviewed, all discussions resolved

cblp

Reviewed 2 of 7 files at r3, 1 of 14 files at r4, 1 of 1 files at r5.
Reviewable status: 5 of 16 files reviewed, all discussions resolved

cblp

Reviewed 1 of 14 files at r4.
Reviewable status: 6 of 16 files reviewed, all discussions resolved

cblp

Reviewed 1 of 1 files at r6.
Reviewable status: 7 of 16 files reviewed, all discussions resolved

cblp

Reviewed 2 of 14 files at r4.
Reviewable status: 9 of 16 files reviewed, all discussions resolved

cblp

Reviewed 1 of 14 files at r4.
Reviewable status: 10 of 16 files reviewed, all discussions resolved

cblp

Reviewed 1 of 3 files at r7.
Reviewable status: 10 of 17 files reviewed, all discussions resolved

cblp

Reviewed 1 of 3 files at r7.
Reviewable status: 11 of 17 files reviewed, all discussions resolved

cblp

Reviewed 5 of 14 files at r4, 1 of 3 files at r7.
Reviewable status: complete! all files reviewed, all discussions resolved

cblp

Reviewable status: all files reviewed, 3 unresolved discussions

a discussion (no related file):
ronRoundtrip

a discussion (no related file):
stack exec ff

a discussion (no related file):
stack exec ff upgrade

cblp

Reviewed 4 of 4 files at r8.
Reviewable status: all files reviewed, 3 unresolved discussions

cblp

Reviewable status: all files reviewed, 3 unresolved discussions

a discussion (no related file):
stack exec ff track

willbasky · 2018-10-30T07:32:34Z

ff-core/lib/FF.hs

+    note_status_assign $ TaskStatus Archived
+
+cmdUnarchive :: MonadStorage m => NoteId -> m (Entity Note)
+cmdUnarchive nid = modifyAndView nid $ note_status_assign $ TaskStatus Active


Хорошо код упростился и более читаемым стал.

willbasky · 2018-10-30T07:33:44Z

ff-core/lib/FF.hs

-        pure ()
+    unless (start <= end) $ throwError "task cannot end before it is started"
+
+note_status_assignIfDiffer


Функция для решения конфликтов двух статусов?
lwwAssignIfDiffer была для любого поля?

willbasky · 2018-10-30T07:38:54Z

ff-core/lib/FF/Github.hs

+        { track_provider   = "github"
+        , track_source     = address
+        , track_externalId
+        , track_url


Почему теперь стиль нижнего подчеркивания вместо camelCase?

willbasky · 2018-10-30T07:46:23Z

ff-core/lib/FF/Types.hs

-singletonTaskModeMap today note = Map.singleton (taskMode today note) [note]
-
-noteView :: NoteId -> Note -> NoteView
-noteView nid Note {..} = NoteView


Теперь все через тип Note? Не нашел, где он объявлен.

willbasky · 2018-10-30T07:49:57Z

ff-core/lib/FF/Upgrade.hs


-import           FF.Storage (Collection, MonadStorage (..), listDocuments,
-                             modify)
 import           FF.Types (Note)

 upgradeDatabase :: MonadStorage m => m ()


Апргрейд базы данных будет происходить в ручном режиме или автоматическом?

cblp

Теперь все через тип Note?

Вроде того

Не нашел, где он объявлен.

Генерится в FF.Types

Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @willbasky)

cblp

Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @cblp and @willbasky)

ff-core/lib/FF.hs, line 309 at r8 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

Хорошо код упростился и более читаемым стал.

Спасибо

cblp

Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @willbasky and @cblp)

ff-core/lib/FF.hs, line 391 at r8 (raw file):

Функция для решения конфликтов двух статусов?

В CRDT нет конфликтов по определению. Эта функция обновляет поле, только если его надо обновить.

lwwAssignIfDiffer была для любого поля?

Да, но использовалась только для одного.

Я завёл задачу о том, чтобы имет возможность обобщать такие конструкции — ff-notes/ron#13

cblp

Reviewable status: all files reviewed, 7 unresolved discussions (waiting on @willbasky and @cblp)

ff-core/lib/FF/Github.hs, line 107 at r8 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

Почему теперь стиль нижнего подчеркивания вместо camelCase?

Мне так кажется более понятным. Например, fooBarBaz — это поле barBaz в структуре foo или поле baz в структуре fooBar? А если написать foo_barBaz или fooBar_baz, то становится понятно.

cblp

Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @willbasky)

a discussion (no related file):
CHANGELOG

willbasky · 2018-10-30T12:31:34Z

В строчках 127-152, templete haskell?

cblp

Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @willbasky and @cblp)

ff-core/lib/FF/Upgrade.hs, line 14 at r8 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

Апргрейд базы данных будет происходить в ручном режиме или автоматическом?

Полное обновление формата — в ручном, если я правильно понял вопрос. По команде ff upgrade.

Но при любом изменении данных новая версия всегда записывается в самом новом формате.

cblp

Reviewed 2 of 2 files at r14.
Reviewable status: all files reviewed, 3 unresolved discussions

For #25

cblp

Reviewed 4 of 4 files at r15.
Reviewable status: all files reviewed, 3 unresolved discussions

cblp

Reviewed 3 of 3 files at r16.
Reviewable status: all files reviewed, 1 unresolved discussion

cblp

Reviewed 1 of 1 files at r17.
Reviewable status: all files reviewed, 1 unresolved discussion

willbasky · 2018-11-02T14:54:00Z

ff-core/lib/FF.hs, line 323 at r16 (raw file):

                (Just eStart, Nothing        , Just end) -> Just (eStart, end)
                (Nothing    , Just (Just end), _       ) -> Just (start,  end)
                (Just eStart, Just (Just end), _       ) -> Just (eStart, end)

что означает eStart, время начала редактирования?

willbasky · 2018-11-02T14:55:25Z

ff-core/lib/FF.hs, line 346 at r16 (raw file):

    note_start_assign start'
    mend <- note_end_read
    case mend of

может mEnd?

…ry format

…e primary format

cblp

Reviewed 1 of 1 files at r18.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @willbasky and @cblp)

ff-core/lib/FF.hs, line 323 at r16 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

что означает eStart, время начала редактирования?

Время начала задачи после редактирования пользователем. Оно же из editStart берётся.

…N as the primary format

cblp

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @willbasky)

ff-core/lib/FF.hs, line 346 at r16 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

может mEnd?

Done.

cblp

Reviewed 1 of 1 files at r19.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @willbasky)

willbasky · 2018-11-02T15:01:09Z

ff-core/lib/FF/Types.hs, line 130 at r16 (raw file):

-}

$(let

Все-таки, мн не ясно, почему для объявления типов используется темплейт хаскель.

willbasky · 2018-11-02T15:01:49Z

ff-core/lib/FF/Types.hs, line 185 at r16 (raw file):

omitted :: Sample a -> Natural
omitted Sample{..} = sample_total - genericLength sample_items

А для этих типов не используется.

cblp

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @willbasky and @cblp)

ff-core/lib/FF/Types.hs, line 130 at r16 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

Все-таки, мн не ясно, почему для объявления типов используется темплейт хаскель.

Для того, чтобы из этой же схемы сгенерить типы и функции в других языках.

cblp

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @willbasky)

ff-core/lib/FF/Types.hs, line 185 at r16 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

А для этих типов не используется.

Эти не входят в схему БД.

willbasky · 2018-11-02T15:06:03Z

ff-core/lib/FF.hs, line 323 at r16 (raw file):

Previously, cblp (Yuriy Syrovetskiy) wrote…

Время начала задачи после редактирования пользователем. Оно же из editStart берётся.

А зачем засекать время начала и конца редактирования?

cblp

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @willbasky)

ff-core/lib/FF.hs, line 323 at r16 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

А зачем засекать время начала и конца редактирования?

Никто его не засекает.

willbasky · 2018-11-02T15:07:42Z

ff-core/lib/FF/Types.hs, line 130 at r16 (raw file):

Previously, cblp (Yuriy Syrovetskiy) wrote…

Для того, чтобы из этой же схемы сгенерить типы и функции в других языках.

То есть это задел на перспективу, чтобы другие из других языков могли пользоваться библиотекой?

cblp

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @willbasky)

ff-core/lib/FF/Types.hs, line 130 at r16 (raw file):

Previously, willbasky (Vladislav Sabanov) wrote…

То есть это задел на перспективу, чтобы другие из других языков могли пользоваться библиотекой?

Чтобы для других языков можно было написать другие библиотеки, совместимые с этими же типами.

cblp force-pushed the ron-storage branch from 6ffa87c to 716d0cb Compare October 29, 2018 06:58

cblp commented Oct 29, 2018

View reviewed changes

cblp force-pushed the ron-storage branch from 2a9dee0 to 5e261f6 Compare October 29, 2018 07:53

cblp commented Oct 29, 2018

View reviewed changes

cblp force-pushed the ron-storage branch from 5e261f6 to dde5c6d Compare October 29, 2018 13:12

cblp commented Oct 29, 2018

View reviewed changes

willbasky reviewed Oct 30, 2018

View reviewed changes

cblp commented Oct 30, 2018

View reviewed changes

cblp commented Nov 1, 2018

View reviewed changes

Use RON as the primary format

4b1f231

For #25

cblp force-pushed the ron-storage branch from 4c39cae to 4b1f231 Compare November 2, 2018 10:24

cblp added 4 commits November 2, 2018 13:29

fixup! Use RON as the primary format

59f9605

fixup! fixup! Use RON as the primary format

32ddb28

fixup! fixup! fixup! Use RON as the primary format

5c62311

fixup! fixup! fixup! fixup! Use RON as the primary format

d5d1442

cblp commented Nov 2, 2018

View reviewed changes

fixup! fixup! fixup! fixup! fixup! Use RON as the primary format

3020c55

cblp commented Nov 2, 2018

View reviewed changes

fixup! fixup! fixup! fixup! fixup! fixup! Use RON as the primary format

0313e97

cblp commented Nov 2, 2018

View reviewed changes

cblp added 2 commits November 2, 2018 17:56

fixup! fixup! fixup! fixup! fixup! fixup! fixup! Use RON as the prima…

89fa7cc

…ry format

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Use RON as th…

4fc213e

…e primary format

cblp commented Nov 2, 2018

View reviewed changes

fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Use RO…

be9225c

…N as the primary format

cblp commented Nov 2, 2018

View reviewed changes

cblp commented Nov 3, 2018

View reviewed changes

cblp merged commit 82ae8ed into master Nov 3, 2018

cblp deleted the ron-storage branch November 3, 2018 08:56

Use RON as the primary format #100

Use RON as the primary format #100

Conversation

cblp commented Oct 28, 2018 • edited Loading

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

willbasky Oct 30, 2018

Choose a reason for hiding this comment

willbasky Oct 30, 2018 • edited Loading

Choose a reason for hiding this comment

willbasky Oct 30, 2018

Choose a reason for hiding this comment

willbasky Oct 30, 2018

Choose a reason for hiding this comment

willbasky Oct 30, 2018

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

willbasky commented Oct 30, 2018

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

willbasky commented Nov 2, 2018

willbasky commented Nov 2, 2018

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

willbasky commented Nov 2, 2018

willbasky commented Nov 2, 2018

cblp left a comment

Choose a reason for hiding this comment

cblp left a comment

Choose a reason for hiding this comment

willbasky commented Nov 2, 2018

cblp commented Oct 28, 2018 •

edited

Loading

willbasky Oct 30, 2018 •

edited

Loading